examples/gcoap_dtls: Increase stack size #17735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
the
Impact: minor
github-actions
bot
added
Area: doc
maribu
added
CI: ready for build
|
looks like |
benpicco
reviewed
Mar 5, 2022
| @@ -94,3 +94,4 @@ ifndef CONFIG_KCONFIG_MODULE_GCOAP | |||
| GCOAP_RESEND_BUFS_MAX ?= 2 | |||
| CFLAGS += -DCONFIG_GCOAP_RESEND_BUFS_MAX=$(GCOAP_RESEND_BUFS_MAX) | |||
| endif | |||
| CFLAGS += -DTHREAD_STACKSIZE_MAIN=\(2*THREAD_STACKSIZE_LARGE\) | |||
There was a problem hiding this comment.
Feels a bit overkill - what is ps saying?
|
I suppose this is still needed, right? |
|
It is also needed with |
|
I'm cleaning up my stale branches currently. I think this is actually still needed. Any change to get this in? (Once someone fixes the surprising amount of stack consumption, this is a change that is trivial to revert.) |
benpicco
approved these changes
Jan 21, 2023
benpicco
added
CI: ready for build
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jan 22, 2023
17735: examples/gcoap_dtls: Increase stack size r=maribu a=maribu ### Contribution description As the title says. The stack size was copied over from `tests/pkg_tinydtls_sock_async` cargo-cult style. Also some typos in the README were fixed. ### Testing procedure Previously on my Nucleo-F767ZI, the CoAP client triggered the MPU stack guard on sending the DTLS hello. With this, the board no longer crashes. ### Issues/PRs references None Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
|
bors cancel |
|
Canceled. |
bors bot
added a commit
that referenced
this pull request
Jan 22, 2023
17735: examples/gcoap_dtls: Increase stack size r=maribu a=maribu ### Contribution description As the title says. The stack size was copied over from `tests/pkg_tinydtls_sock_async` cargo-cult style. Also some typos in the README were fixed. ### Testing procedure Previously on my Nucleo-F767ZI, the CoAP client triggered the MPU stack guard on sending the DTLS hello. With this, the board no longer crashes. ### Issues/PRs references None 19184: pkg/tinydtls: bump version r=maribu a=benpicco Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de> Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
|
bors cancel let's see if we can get three PRs into the merge train. |
|
Canceled. |
bors bot
added a commit
that referenced
this pull request
Jan 22, 2023
17735: examples/gcoap_dtls: Increase stack size r=maribu a=maribu ### Contribution description As the title says. The stack size was copied over from `tests/pkg_tinydtls_sock_async` cargo-cult style. Also some typos in the README were fixed. ### Testing procedure Previously on my Nucleo-F767ZI, the CoAP client triggered the MPU stack guard on sending the DTLS hello. With this, the board no longer crashes. ### Issues/PRs references None 19184: pkg/tinydtls: bump version r=maribu a=benpicco Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de> Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
|
bors cancel |
|
Canceled. |
bors bot
added a commit
that referenced
this pull request
Jan 22, 2023
17735: examples/gcoap_dtls: Increase stack size r=maribu a=maribu ### Contribution description As the title says. The stack size was copied over from `tests/pkg_tinydtls_sock_async` cargo-cult style. Also some typos in the README were fixed. ### Testing procedure Previously on my Nucleo-F767ZI, the CoAP client triggered the MPU stack guard on sending the DTLS hello. With this, the board no longer crashes. ### Issues/PRs references None 19182: pkg/libfixmath: bump version r=maribu a=benpicco 19184: pkg/tinydtls: bump version r=maribu a=benpicco Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de> Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Jan 22, 2023
17735: examples/gcoap_dtls: Increase stack size r=maribu a=maribu ### Contribution description As the title says. The stack size was copied over from `tests/pkg_tinydtls_sock_async` cargo-cult style. Also some typos in the README were fixed. ### Testing procedure Previously on my Nucleo-F767ZI, the CoAP client triggered the MPU stack guard on sending the DTLS hello. With this, the board no longer crashes. ### Issues/PRs references None Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
|
Build failed: |
Also fix some typos in the readme.
maribu
force-pushed
the
examples/gcoap_dtls
branch
from
08d8d8d to
965b555
Compare
|
rebased and ran the tool to update the bors retry |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
Build succeeded: |
|
Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
As the title says. The stack size was copied over from
tests/pkg_tinydtls_sock_asynccargo-cult style. Also some typos in the README were fixed.Testing procedure
Previously on my Nucleo-F767ZI, the CoAP client triggered the MPU stack guard on sending the DTLS hello. With this, the board no longer crashes.
Issues/PRs references
None