Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist/tools: rename directory esptool to esptools to use it for multiple tools #17742

Merged
merged 1 commit into from
Mar 4, 2022
Merged

dist/tools: rename directory esptool to esptools to use it for multiple tools #17742

merged 1 commit into from
Mar 4, 2022

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR renames dist/tools/esptool to dist/tools/esptools.

The directory dist/tools/esptool already contains a number of ESP tools and not only the esptool.py. During the migration to Espressif's precompiled GCC 8.4.0 toolchain, some helper scripts will also be placed there, as it makes no sense to create a separate directory for them. Therefore, it makes more sense to name the directory esptools instead of esptool, since various ESP-related tools are stored there.

Testing procedure

Green CI with enabled test run.

Issues/PRs references

Prerequisite for PR #17601

@gschorcht
dist/tools: rename esptool to esptools to use it for several tools
cbbd02d 
The directory `dist/tools/esptool` already contains a couple of ESP tools and not only esptool.py. As the location for a couple of ESP related tools, it is more clear to call it `esptools` instead of `esptool`.
@github-actions github-actions bot added Area: build system Area: Build system Area: cpu Area: CPU/MCU ports Area: tools Area: Supplementary tools Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Mar 4, 2022
@gschorcht gschorcht changed the title dist/tools: rename esptool to esptools to use it for multiple tools dist/tools: rename directory esptool to esptools to use it for multiple tools Mar 4, 2022
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Mar 4, 2022
@leandrolanzieri leandrolanzieri added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines labels Mar 4, 2022
@leandrolanzieri leandrolanzieri merged commit c33cfdf into RIOT-OS:master Mar 4, 2022
@gschorcht
Copy link
Contributor Author

Thanks for reviewing and merging.

@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: cpu Area: CPU/MCU ports Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: ESP Platform: This PR/issue effects ESP-based platforms Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.04
Development

Successfully merging this pull request may close these issues.
3 participants
@gschorcht @leandrolanzieri @OlegHahm