Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package tiny-vcdiff #17797
Add package tiny-vcdiff #17797
Changes from all commits
5571d5c
e2e4dbe
368e770
0f1a1dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should now be possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vcdiff_mtd_t
requireswrite_size
to be known at compile time to adjust buffer sizes. But at least anassert()
would be nice to have.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use
mtd->work_area
instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would add the dependency
mtd_write_page
. Currently, I'm not using any of the write page features. Adding this module would add unnecessary code just to have the (mtd_write_page
-internal) buffer at hand. It feels a little bit hacky to me.I'd say having
assert()
s in place that make sure the buffer is aligned and large enough would be a good thing to have in place.The default of 4 bytes seems to be a size that fits all
mtd
devices available in RIOT (IIRC) and isn't wasteful in my opinion.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For
mtd_flashpage
it can be larger than 4, same for SD cards (but those are usually used with a filesystem)