Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: add support for nucleo-f439zi #17827

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Mar 18, 2022

Contribution description

This PR adds support for another STM32 nucleo board, the nucleo-f439zi which is very similar to the nucleo-f429zi. It's also interesting because it provides an Ethernet port.

Testing procedure

  • I tested all features provided except SPI, but according to the datasheet and board documentation the provided configuration is ok
  • I ran compile_and_test_for_board.py and got the following result:
ERROR:nucleo-f439zi:Tests failed: 2
Failures during compilation:
- [tests/rust_minimal](tests/rust_minimal/compilation.failed)

Failures during test:
- [tests/malloc](tests/malloc/test.failed)

I don't understand the malloc failure but I get the same error on nucleo-f429zi. Maybe it's also related to #17439 because the error seems similar:

Allocated 128 Bytes at 0x0x2002fd70, total 170944
Allocated 128 Bytes at 0x0x2002fe08, total 171080
Allocated 128 Bytes at 0x0x2002fea0, total 171216
Allocated 128 Bytes at 0x0x2002ff38, total 171352
Allocated 128 Bytes at 0x0x2002ffd0, total 171488

Context before hardfault:
   r0: 0x2002ffd0
   r1: 0x00000040
   r2: 0x20030050
   r3: 0x20030001
  r12: 0x0000000a
   lr: 0x08000275
   pc: 0x080014de
  psr: 0x81000000

FSR/FAR:
 CFSR: 0x00000400
 HFSR: 0x40000000
 DFSR: 0x00000008
 AFSR: 0x00000000
Misc
EXC_RET: 0xfffffffd
Active thread: 1 "main"
Attempting to reconstruct state for debugging...
In GDB:
  set $pc=0x80014de
  frame 0
  bt

ISR stack overflowed by at least 16 bytes.

For the rust build failure, I think it's a toolchain issue locally (I didn't try with BUILD_IN_DOCKER=1)

Issues/PRs references

None

@github-actions github-actions bot added Area: boards Area: Board ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework labels Mar 18, 2022
@github-actions github-actions bot added the Area: tools Area: Supplementary tools label Mar 18, 2022
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 18, 2022
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Mar 18, 2022
@benpicco
Copy link
Contributor

It's also interesting because it provides an Ethernet port.

I assume you tested that one then? 😃

I don't understand the malloc failure

I also see this on stm32f429i-disco - it's unrelated to this PR but something seems to be really wrong with our heap configuration on STM32 😟

Simple addition, please rebase - then this can go in.

@aabadie
Copy link
Contributor Author

aabadie commented Mar 21, 2022

I assume you tested that one then?

Sure, I just have to rebase to fix conflicts.

@aabadie aabadie force-pushed the pr/board/nucleo-f439zi branch from ce8a3dc to a7c1be8 Compare March 21, 2022 07:11
@aabadie
Copy link
Contributor Author

aabadie commented Mar 21, 2022

I just have to rebase to fix conflicts.

Done

@aabadie aabadie enabled auto-merge March 21, 2022 08:26
@aabadie aabadie merged commit a2146ac into RIOT-OS:master Mar 21, 2022
@aabadie aabadie deleted the pr/board/nucleo-f439zi branch March 21, 2022 08:29
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants