Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/suit: save seq_number when parsing manifest #17939

Merged
merged 3 commits into from
Apr 15, 2022

Conversation

fjmolinas
Copy link
Contributor

Contribution description

At the end of an update the manifest seq_no should set "somewhere". For firmware update, this is done implicitly since the seq_no is contained in the firmware update. But for other storage units, it needs to be obtained from the manifest.

Therefore when parsing the manifest save the sequence number, and for ram storage set it during install.

Testing procedure

In master, the sequence_no is never checked when using RAM storage, with this PR it is (although only ephemerally). Follow the README.native.md

Or alternatively, leverage #16771.

@github-actions github-actions bot added Area: OTA Area: Over-the-air updates Area: sys Area: System labels Apr 14, 2022
@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 14, 2022
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Apr 15, 2022
@benpicco benpicco merged commit c610b1f into RIOT-OS:master Apr 15, 2022
@fjmolinas fjmolinas deleted the pr_suit_manifest_ram_seq_no branch April 15, 2022 12:25
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OTA Area: Over-the-air updates Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants