-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys/suit/storage/vfs: initial import #17943
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition, just one question: How are the different SUIT storage backends identified?
ca2db6f
to
c0a65a8
Compare
Rebased to get the suit changes in |
c0a65a8
to
00f973b
Compare
0ed0e04
to
3f0ab9f
Compare
I adapted the |
I think the Readme needs an update too, it only tells me how to load a file to RAM. (Also:
It won't be able to create the tap device - but with gcoap_fileserver and socket_zep we should be able to run it on CI, just like |
The PR title and some commit messages are unclear about whether this is SUIT specific (sys/suit/storage) or not (sys/storage). Appears to be the former from a quick glance. |
fixed |
@benpicco is addressing the missing README enough to get this in? Or will you want to wait for you to add the |
Having a test for this is entirely orthogonal, I just want the readme update so I can test it myself. |
Sorry I missed this comment, will address next week, sorry for the delay. |
@benpicco I just updated the README, there is actually very little to adapt from the regular RAM workflow in the README, only the install-id. |
/* add handled storages */ | ||
#if IS_USED(MODULE_SUIT_STORAGE_VFS) | ||
XFA_USE(char*, suit_storage_files_reg); | ||
#ifdef BOARD_NATIVE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why limit this to native
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just adding this storage for native in the test, same question can be asked for RAM storage
Looks good to me, feel free to squash. |
b72093f
to
deaf0ad
Compare
squashed |
Rebased to get the pthon fix in. |
Hm I think you only squashed and didn't rebase - the python test is still failing. |
deaf0ad
to
d33d0a4
Compare
Contribution description
This PR extends
suit/storage
units withvfs
. It also makessuit/storage
usexfa
to allow for easy declaration of storage units, e.g.: backup filesystem storage can be added:Testing procedure
I'll adapt the
suit/example_update
examples to run on native and use this storage unit once #16771 is in.Issues/PRs references
Somewhat related to #17962
Depends on #17941
Could use #16771