-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards/stm32f7508-dk: add support #17954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
requested review from
leandrolanzieri,
jia200x,
cgundogan,
miri64,
smlng,
MichelRottleuthner and
fjmolinas
as code owners
April 14, 2022 19:23
github-actions
bot
added
Area: boards
Area: Board ports
Area: build system
Area: Build system
Area: doc
Area: Documentation
Area: examples
Area: Example Applications
Area: Kconfig
Area: Kconfig integration
Area: tests
Area: tests and testing framework
labels
Apr 14, 2022
aabadie
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Apr 14, 2022
aabadie
force-pushed
the
pr/boards/stm32f750n8-dk
branch
from
April 14, 2022 19:39
e1fabe3
to
08d4e1d
Compare
aabadie
force-pushed
the
pr/boards/stm32f750n8-dk
branch
from
April 14, 2022 19:44
08d4e1d
to
2f87b68
Compare
This commit also makes some cleanup in the files since add_insufficient_memory_board.sh was used for the update
aabadie
force-pushed
the
pr/boards/stm32f750n8-dk
branch
from
April 15, 2022 10:52
2f87b68
to
843df70
Compare
benpicco
reviewed
Apr 15, 2022
- an ethernet port | ||
- 2 user USB ports (FS and HS) | ||
- 2 user digital microphones | ||
- 128M-bit external Quas-SPI flash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we wire that up as a MTD device in SPI mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably but I haven't tried (yet)
benpicco
approved these changes
Apr 15, 2022
aabadie
changed the title
boards/stm32f750n8-dk: add support
boards/stm32f7508-dk: add support
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: boards
Area: Board ports
Area: build system
Area: Build system
Area: doc
Area: Documentation
Area: examples
Area: Example Applications
Area: Kconfig
Area: Kconfig integration
Area: tests
Area: tests and testing framework
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds support for the stm32f7508-dk board. Features wise it's exactly the same board as the stm32f746g-disco, the only difference is the microcontroller model. This one has an stm32f750n8 with much less space on ROM (only 64KB) but the same amount of RAM (340KB).
We could certainly provide more ROM by adding support for the external Quad SPI Flash (8MB).
The port is using a strategy similar to the shared stm32f429i-disc1/stm32f429i-disco. So not so much code is added, it just reuse the port from the stm32f746g-disco but declares a difference CPU model.
Since the board only has 64KB of flash, it's added to a lot of
Makefile.ci
, this change is in a separate because there are unrelated changes due to the use of theadd_insufficient_memory_board.sh
script.Testing procedure
compile_and_test_for_board.py
:I think the test failures are unrelated to this port.
Issues/PRs references