pm: don't (un)block IDLE mode #17974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already unblocked and will trigger an assertion. The code is still broken as other modes might be unblocked too, but at least it is just as broken as it was before RIOT-OS#17895
benpicco
added
the
Process: needs backport
github-actions
bot
added
Area: examples
benpicco
added
the
CI: ready for build
kaspar030
reviewed
Apr 21, 2022
88 tasks
OlegHahm
approved these changes
Apr 21, 2022
|
let's see if this fixes the LoRaWAN issue |
benpicco
commented
Apr 21, 2022
| /* sleeping is currently not supported, block all sleep modes */ | ||
| for (uint8_t i = 0; i < PM_NUM_MODES; i++) { | ||
| /* sleeping is currently not supported, block all sleep modes except IDLE */ | ||
| for (uint8_t i = 0; i < PM_NUM_MODES - 1; i++) { | ||
| pm_block(i); |
There was a problem hiding this comment.
tbh I don't see what's the point of this code - sleep modes are blocked by default on RIOT anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This is already unblocked and will trigger an assertion.
The code is still broken as other modes might be unblocked too, but at least it is just as broken as it was before #17895
Testing procedure
examples/lorawanshould no longer crash on most boards.(should still crash on samd21 boards as it would since ed9f740)
Issues/PRs references
follow-up to #17895