nanocoap_sock: only abort nanocoap_sock_get_blockwise() on negative error #18037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror Some user callbacks might just return the result of some other operation that returns written bytes or negative error. Let's not break those, only consider negative callback returns an error.
benpicco
requested review from
miri64,
haukepetersen,
PeterKietzmann and
cgundogan
as code owners
benpicco
added
the
Type: bug
github-actions
bot
added
Area: CoAP
benpicco
added
Impact: minor
maribu
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Some user callbacks might just return the result of some other operation that returns written bytes or negative error.
Let's not break those, only consider negative callback returns an error.
Testing procedure
I discovered this when rebasing #17937 onto master.
Only the first block of a file would be written.
This is because the callback just returns the result of
vfs_write(). This used to work fine (becausenanocoap_sock_request_cb()would change the return code based on the CoAP response code), now it is handed through to the user, breakingnanocoap_sock_get_blockwise().Issues/PRs references
follow-up to #17950