-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nanocoap_link_format: add helper function to parse Link Format #18134
Conversation
@fengelhardt may be interested in this |
Hmm, from the text it more looks like this is an utility to obtain a CoAP Resource that is in the CoRE Link Format, rather than anything specific to Resource Directories. RDs do use the CoRE Link Format (due to the lack of decent CBOR based alternatives not yet being standardized), but it is also notably used by the default resource discovery. Maybe it could be named better to indicate that it is useful for interaction with any server that provides a list of links in the CoRE Link Format? Out of scope I guess, but it may be useful to also be able to add URI Query Options. E.g. querying |
Thank you, I was searching for what was the proper name for this. |
2c5d3e0
to
09df15b
Compare
Murdock results✔️ PASSED f06c763 sys/shell: ncget: make use of nanocoap_link_format_get() ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
11f9ec1
to
bdabc7b
Compare
bdabc7b
to
f06c763
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Code looks good to me. I'd say we wait the three days to hard feature freeze before merging this, but it never hurts to have an ACK :)
bors merge |
bors cancel |
Canceled. |
Build succeeded: |
Contribution description
This moves the code to parse the link format from the
ncget
shell command to a common location and makes it more general.A callback is called for each resource path in the directory.
Testing procedure
ncget
still works as before for listing directories:Issues/PRs references