-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/doc: some additions and reorganization of doc page #18190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changing the heading style seems ok for me (RiOT-doc just uses both in about equal amount)
reordering makes sense (more likely someone wants to exec (a) test(s))
I think the new cleanup paragraph need some extra words maybe also advertise a less aggressive cleanup strategy.
|
||
To delete all of this files go to main RIOT directory and execute command: | ||
|
||
make distclean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
distclean
might remove a bunch of files that are not test specific.
(e.g. pkg sources, documentation if generated, other applications build)
I think this needs to be written down (warning) (distclean is just very not specific for test)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for review! Could you hint me other 'less aggressive cleanup' methods? distclean
was the only one which I found when after running tests for three boards my file system was completely full.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make clean
"Cleaning all build products for the current board" If you know know which board you just tested.
This will spare you the pkg-download for the next board you test and the doc rebuild (if you like to have a local doc)
compile_and_test_for_board.py
also has a --clean-after
flag that might fit your need
or --compile-targets clean
if you like to cleanup later
I put me this Makefile into tests/
and examples/
to do test-builds. (just building not testing) (the ignore list are for build chains that i do not have installed, the DONE files generated are for speed up repeated builds) not sure if this helps your Usecase.
DIRS := $(wildcard */)
IGNORE_EXAMPLES := mallinfo \
rust-gcoap \
rust-hello-world \
suit_update \
#
IGNORE_TESTS := cpu_avr8_xmega_drivers \
cpu_efm32_features \
cpu_efm32_drivers \
driver_ws281x \
driver_esp_eth \
mcuboot \
pkg_emlearn \
pkg_nanopb \
pkg_tensorflow-lite \
rust_minimal \
suit_manifest \
sys_stdio_semihosting \
ztimer_until \
#
IGNORE := $(INGNORE) $(IGNORE_EXAMPLES) $(IGNORE_TESTS)
DIRS := $(filter-out $(addsuffix /,$(IGNORE)), $(DIRS))
CLEANLIST := $(addsuffix /bin,$(DIRS))
DIRSDONE := $(addsuffix /bin/DONE,$(DIRS))
all: $(DIRSDONE)
@echo FINISHED ALL
$(DIRSDONE):
$(MAKE) -C $(subst /bin/DONE,,$@)
touch $@
$(DIRS): FORCE
$(MAKE) -C $@
clean_all: undone
rm -rf $(CLEANLIST)
undone: FORCE
rm $(DIRSDONE)
FORCE:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for hints. I will test it and update this section accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I update section concerning various methods for cleaning intermediate files. @kfessel could you review my changes?
b3dab8c
to
43f2e83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reordering 👍
style 👍
reads well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please squash
438698b
to
eb91435
Compare
Thanks for review. All commits squashed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpick inline. I am not insistent on the wording I suggest, feel free to rephrase/extend as you like. Please squash/amend directly.
beaae30
to
f13794f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This improves the current documentation
Contribution description
During running all tests for few boards I noticed some lack of information in the tests doc page, for example, information how execute all automatic tests for particular board or about cleaning intermediate files. Moreover, current version of the documentation mixes information about running and implementation of tests.
My contribution:
Testing procedure
Issues/PRs references
None