Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/slipdev: fix off-by-one error in _recv() #18229

Closed
wants to merge 3 commits into from
Closed

drivers/slipdev: fix off-by-one error in _recv() #18229

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8acd18
drivers/slipdev: fix off-by-one error in _recv()
benpicco Jun 18, 2022
f7bccf0
fixup! drivers/slipdev: fix off-by-one error in _recv()
benpicco Jun 22, 2022
18d96e9
fixup! fixup! drivers/slipdev: fix off-by-one error in _recv()
benpicco Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/slipdev/slipdev.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ static int _recv(netdev_t *netdev, void *buf, size_t len, void *info)
tmp = slipdev_unstuff_readbyte(ptr, byte, &escaped);
ptr += tmp;
res += tmp;
if ((unsigned)res > len) {
if ((unsigned)res >= len) {
while (byte != SLIPDEV_END) {
/* clear out unreceived packet */
byte = tsrb_get_one(&dev->inbuf);
Expand Down