ieee802154: add default max frame retransmissions config #18264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jia200x
requested review from
leandrolanzieri,
MrKevinWeiss,
miri64,
haukepetersen,
PeterKietzmann and
cgundogan
as code owners
github-actions
bot
added
Area: Kconfig
benpicco
approved these changes
Jun 27, 2022
benpicco
added
the
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds a IEEE 802.15.4 configuration for setting the maximum number of frame retransmissions.
Thereby the IEEE802154_SUBMAC_MAX_RETRANSMISSIONS is not needed anymore and the user can simply set the number of retransmissions from Kconfig/CFLAGS.
Testing procedure
Try e.g
examples/gnrc_networkingwith any IEEE 802.15.4 HAL based radio (e.g nrf52840). Try pinging with a stress configuration (e.gping <addr> -c 50 -s 1024 -i 200.Then, set CONFIG_IEEE802154_DEFAULT_MAX_FRAME_RETRANS to a low value (e.g 1). Repeat the procedure. Packet losses should increase.
Issues/PRs references
None