Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/lv_drivers: cleanup Makefile #18302

Merged
merged 1 commit into from
Jul 8, 2022
Merged

pkg/lv_drivers: cleanup Makefile #18302

merged 1 commit into from
Jul 8, 2022

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Jul 6, 2022

Contribution description

While working on #18301, I noticed some inconsistencies in this Makefile. This PR addresses them:

  • the IGNORE_MODULES variable is empty and there's no way to modify it. So let's just drop it
  • the PHONY targets are wrong
  • there's a tiny generalization of the lv_drivers_% target. I can drop that change if this is controversial. Normally each possible drivers (sdl, wayland, win32drv, gtkdrv) should work with that but I don't think they are used by this package anyway.

Testing procedure

  • Green Murdock
  • tests/pkg_lvgl and tests/pkg_lvgl_touch are still working on native (so with the sdl driver)

Issues/PRs references

None

@github-actions github-actions bot added the Area: pkg Area: External package ports label Jul 6, 2022
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 6, 2022
fjmolinas
fjmolinas approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aabadie aabadie merged commit d4d37aa into RIOT-OS:master Jul 8, 2022
@aabadie aabadie deleted the pr/pkg/lv_drivers_cleanup branch July 8, 2022 12:50
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

Assignees
No one assigned
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
3 participants
@aabadie @fjmolinas @chrysn