Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns_cache: synchronize access with mutex [backport 2022.07] #18342

Merged
merged 1 commit into from
Jul 20, 2022
Merged

dns_cache: synchronize access with mutex [backport 2022.07] #18342

merged 1 commit into from
Jul 20, 2022

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jul 20, 2022

Backport of #18330

Contribution description

In #18329 (comment), @benpicco realized, that synchronization of cache access is missing for dns_cache. This adds the missing synchronization.

Testing procedure

tests/unittests should still pass.

Issues/PRs references

Follow-up on #18318.

@miri64 miri64 added Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Jul 20, 2022
@miri64 miri64 requested a review from benpicco July 20, 2022 08:34
@miri64 miri64 mentioned this pull request Jul 20, 2022
Merged
@benpicco benpicco requested a review from chrysn July 20, 2022 08:54
@chrysn chrysn enabled auto-merge July 20, 2022 09:52
@chrysn chrysn merged commit eaf230e into RIOT-OS:2022.07-branch Jul 20, 2022
@miri64 miri64 deleted the backport/2022.07/dns_cache/fix/add-mutex branch July 20, 2022 20:27
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@haukepetersen haukepetersen Awaiting requested review from haukepetersen haukepetersen is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan cgundogan is a code owner

@chrysn chrysn Awaiting requested review from chrysn

Assignees
No one assigned
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @benpicco @chrysn