unittest/main: do not intialize xtimer if ztimer_xtimer_compat #18352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfessel
added
CI: ready for build
benpicco
approved these changes
Jul 21, 2022
This was referenced Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@miri64 found an issue with unittest and ztimer_sleep in
#17680 (comment)
PR #18312 identified a potential double initialization of ztimer.
Contribution description
this removes the xtimer initialzation call if xtimer is used via ztimer_xtimer_compat. (this is the same behavior found in
auto_init)Testing procedure
see #18312
Issues/PRs references