-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnrc: make pseudo-modules explicit + documentation improvements #18727
Merged
miri64
merged 5 commits into
RIOT-OS:master
from
miri64:gnrc/enh/explicit-pseudomodules
Oct 14, 2022
Merged
gnrc: make pseudo-modules explicit + documentation improvements #18727
miri64
merged 5 commits into
RIOT-OS:master
from
miri64:gnrc/enh/explicit-pseudomodules
Oct 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
the
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
label
Oct 12, 2022
miri64
requested review from
haukepetersen,
PeterKietzmann and
cgundogan
as code owners
October 12, 2022 09:33
github-actions
bot
added
Area: build system
Area: Build system
Area: network
Area: Networking
Area: sys
Area: System
labels
Oct 12, 2022
benpicco
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Oct 12, 2022
benpicco
approved these changes
Oct 12, 2022
Murdock results✔️ PASSED f7510cf gnrc_nettype: improve documentation on modules made explicit
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
miri64
added
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
and removed
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Oct 12, 2022
maribu
added
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
and removed
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Oct 13, 2022
maribu
added
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
and removed
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Oct 13, 2022
dylad
added
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
and removed
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Oct 13, 2022
maribu
added
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
and removed
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: build system
Area: Build system
Area: network
Area: Networking
Area: sys
Area: System
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
As stated elsewhere, pseudomodules should not be defined by wildcards for several reasons. So I thought to set an example, by starting with that with GNRC's pseudomodules. Since I already touched those, I also went ahead and cleaned up some documentation on the modules I touched and also cleaned-up the somewhat gone out of order
gnrc_nettype_t
.Testing procedure
All applications should still build, the doc page (especially the page on
pseudomodules
,gnrc_nettype
, andgnrc_dhcpv6_client
should look better now.Issues/PRs references
Follow-up on discussions in #18649 and #18698