Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc: make pseudo-modules explicit + documentation improvements #18727

Merged
merged 5 commits into from
Oct 14, 2022

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 12, 2022

Contribution description

As stated elsewhere, pseudomodules should not be defined by wildcards for several reasons. So I thought to set an example, by starting with that with GNRC's pseudomodules. Since I already touched those, I also went ahead and cleaned up some documentation on the modules I touched and also cleaned-up the somewhat gone out of order gnrc_nettype_t.

Testing procedure

All applications should still build, the doc page (especially the page on pseudomodules, gnrc_nettype, and gnrc_dhcpv6_client should look better now.

Issues/PRs references

Follow-up on discussions in #18649 and #18698

@miri64 miri64 added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Oct 12, 2022
@github-actions github-actions bot added Area: build system Area: Build system Area: network Area: Networking Area: sys Area: System labels Oct 12, 2022
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 12, 2022
@riot-ci
Copy link

riot-ci commented Oct 12, 2022

Murdock results

✔️ PASSED

f7510cf gnrc_nettype: improve documentation on modules made explicit

Success Failures Total Runtime
1983 0 1983 07m:58s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

@miri64 miri64 enabled auto-merge October 12, 2022 11:41
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 12, 2022
@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 13, 2022
@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 13, 2022
@dylad dylad added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 13, 2022
@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 13, 2022
@miri64 miri64 merged commit c94c32d into RIOT-OS:master Oct 14, 2022
@miri64 miri64 deleted the gnrc/enh/explicit-pseudomodules branch October 16, 2022 18:38
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants