boards/blxxxpill-128kib: default to CDC ACM for stdio #18743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDC ACM stdio adds 10k ROM and 2k RAM, so only enable it for the larger board variants.
benpicco
force-pushed
the
boards/blxxxpill-128kib_cdc-acm
branch
from
1b4d17f to
d2dbf9e
Compare
benpicco
requested review from
leandrolanzieri,
jia200x and
MrKevinWeiss
as code owners
benpicco
added
the
CI: ready for build
Murdock results✔️ PASSED 2fd6cf7 tests: update Makefile.ci for blxxxpill-128kib with CDC ACM
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
maribu
approved these changes
Oct 15, 2022
|
A few Makefile.ci bumps are needed. The xtimer test build failures look interesting, though |
|
I think it's because CDC ACM is pulling in ZTimer. |
benpicco
requested review from
miri64,
smlng,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
github-actions
bot
added
Area: examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
CDC ACM stdio adds 10k ROM and 2k RAM, so only enable it for the larger board variants.
Testing procedure
Issues/PRs references