drivers/sdcard_spi: make use of crc16_ccitt_false_update()

[benpicco]

Contribution description

Use crc16_ccitt instead of ucrc16.
This can be speed up by using a look-up table if desired and does not use more memory in the default configuration.

In fact, it saves some bytes compared to the generic CRC implementation:

before

   text	   data	    bss	    dec	    hex	
  62808	    892	  43688	 107388	  1a37c	

after

   text	   data	    bss	    dec	    hex	
  62744	    892	  43688	 107324	  1a33c	

Testing procedure

SD card still works:

2022-10-20 00:42:07,483 # main(): This is RIOT! (Version: 2023.01-devel-92-g10296)

> ls /sd0
2022-10-20 00:42:12,533 # test/
2022-10-20 00:42:12,534 # hello.txt	19 B
2022-10-20 00:42:12,536 # total 1 files

> vfs r /sd0/hello.txt
2022-10-20 00:45:13,936 # 00000000: 4865 6c6c 6f20 6672 6f6d 204c 696e 7578  Hello from Linux

Issues/PRs references

[riot-ci]

Murdock results

✔️ PASSED

f7197ba drivers/sdcard_spi: make use of crc16_ccitt_false_update()

Success	Failures	Total	Runtime
1991	0	1991	06m:32s

Artifacts

• Documentation preview

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

[maribu]

I assume that you have verified that the CRC is unchanged, e.g. by testing that the driver still works.

[benpicco]

Sure, I posted the test results above :)