Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/lvgl: Change all references of LittlevGL to LVGL #18788

Merged
merged 4 commits into from
May 8, 2023

Conversation

OkiStuff
Copy link
Contributor

Change all references of LittlevGL to LVGL in pkg/lvgl/doc.txt per request of LVGL team (lvgl/lvgl#3761)

Contribution description

Changing parts of the pkg/lvgl/doc.txt to replace "LittlevGL" to LVGL as per request of the LVGL team

Issues/PRs references

lvgl/lvgl#3761

@github-actions github-actions bot added Area: doc Area: Documentation Area: pkg Area: External package ports labels Oct 24, 2022
@bergzand bergzand added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Oct 24, 2022
@benpicco benpicco requested a review from aabadie October 24, 2022 21:09
@benpicco
Copy link
Contributor

Thank you for the patch!

git grep -i LittlevGL shows some more occurrences though 😉

One more thing: please prefix the commit message with the subsystem (pkg/lvgl:) to keep the git log tidy.

@OkiStuff
Copy link
Contributor Author

Will do

@OkiStuff OkiStuff changed the title Change all references of LittlevGL to LVGL in doc.txt (pkg/lvgl) Change all references of LittlevGL to LVGL in doc.txt Oct 25, 2022
@OkiStuff OkiStuff changed the title (pkg/lvgl) Change all references of LittlevGL to LVGL in doc.txt pkg/lvgl: Change all references of LittlevGL to LVGL in doc.txt Oct 25, 2022
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Oct 25, 2022
@OkiStuff
Copy link
Contributor Author

Changed all instances of LittlevGL to LVGL when applicable and fixed the merge conflicts in the Makefile (I assumed they were caused by a new version of the LVGL package being pushed)

@Citrullin
Copy link
Contributor

@OkiStuff Can you squash your commits?

@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 8, 2023
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I allowed myself to rebase and squash a bit this PR. I removed the release-notes.txt change for history. The changes are good otherwise.

ACK

@riot-ci
Copy link

riot-ci commented May 8, 2023

Murdock results

✔️ PASSED

e8f8970 tests/pkg_lvgl_touch: Replace LittlevGL to LVGL

Success Failures Total Runtime
6931 0 6931 09m:13s

Artifacts

@aabadie
Copy link
Contributor

aabadie commented May 8, 2023

bors merge

@aabadie aabadie changed the title pkg/lvgl: Change all references of LittlevGL to LVGL in doc.txt pkg/lvgl: Change all references of LittlevGL to LVGL May 8, 2023
@bors
Copy link
Contributor

bors bot commented May 8, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit b93328d into RIOT-OS:master May 8, 2023
@Citrullin
Copy link
Contributor

@OkiStuff Congrats. Your first merge :)

@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants