-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards/dwm1001: add saul_gpio support #18818
boards/dwm1001: add saul_gpio support #18818
Conversation
I tried ammending the commit message with quotes to avoid automatically linking to the "InGroup" user, but that didn't work. |
Murdock results✔️ PASSED f17bd43 boards/dwm1001: add saul_gpio support
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
I'm not quite sure what you mean, but please squash your commits |
I think I have squashed the commits, although I may have simply caused a mess... Let me know if I should just start a fresh pull-request. |
Huh, all looks good. There is only a single commit and it only touches the two files it needs. |
@@ -1,5 +1,6 @@ | |||
ifneq (,$(filter saul_default,$(USEMODULE))) | |||
USEMODULE += lis2dh12_spi | |||
USEMODULE += saul_gpio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah KConfig needs an update too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
boards/dwm1001: rename "@InGroup" to match board.h boards/dwm1001: correct documentation added "HAVE_SAUL_GPIO"
Contribution description
Add saul support for the dwm1001-dev's LEDs and "USER" button.
The pin macros were already present for this board, all that remained was to add the
gpio_params.h
header and include thesaul_gpio
pseudomodule in the board'sMakefile.dep
.Added LEDs:
Added button:
Testing procedure
Below is the terminal output where each LED has been toggled by shell command, and a before/after of pressing the "USER" button.
Issues/PRs references