-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/cpy2remed: add support for NOD_xxxx removable media #18824
tools/cpy2remed: add support for NOD_xxxx removable media #18824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static-tests
has some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some style suggestions inline. Also note that you are mixing tabs and spaces in the file. Please use four spaces for indent for consistence within RIOT.
1bea8e7
to
0ac797e
Compare
I have to replace inline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me.
I don't have a board to test this and it's a bit noisy for my taste, but other programmers produce a lot more output, so people are probably used to that 😉
lgtm. The final line is missing a newline. (This shouldn't happen when the editor is properly configured. My suggestion is to check the editor config, as making sure the last line is correctly terminated is a task bette left to machines.) Also, the indent is still inconsistent. Please double check that you have 4 spaces per level of indentation. Maybe we should provide some setting files for the most common editors. I think VS code is what most people use these days, but it sucks without manually adjusting the config. Maybe we should just add some config to the repo, so that it works out of the box with RIOT. |
0ac797e
to
4cb2ed5
Compare
I fix last line issue as well as remaining indentation mismatches. Now formatting should be OK. |
Murdock results✔️ PASSED 4cb2ed5 tools/cpy2remed: add support for removable media name NOD_xxxx
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
Contribution description
Newly manufactured Nucleo boards use NOD_xxxx removable media name instead of older NODE_xxxx. The rest of name remains the same. For example newly purchased F429 have name NOD_F429ZI, while older one NODE_F429ZI.
This PR adds to cpy2remed programmer ability to program both types of removable media names.
Testing procedure
Try flashing Nucleo board with new removable media name - NOD_xxxx . Without this PR process failed.
With this PR you could program it, as well as, other boards with NODE_xxx names.
Issues/PRs references
None