Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/slipdev: fix off-by-one error in _recv() #18826

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Oct 31, 2022

Contribution description

This fixes the off-by-one error in SLIP the same way as it was fixed in ethos.

Previously I tried to make SLIP use the chunked ringbuffer to handle this with common code or clean up the driver while fixing the bug, but neither reached consensus.

So this minimal solution should fix the bug while not touching the driver otherwise.

Testing procedure

Issues/PRs references

alternative to #18229, #18066
same as #18823

@benpicco benpicco requested a review from miri64 as a code owner October 31, 2022 21:57
@github-actions github-actions bot added the Area: drivers Area: Device drivers label Oct 31, 2022
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 31, 2022
@benpicco benpicco requested a review from maribu October 31, 2022 22:05
@riot-ci
Copy link

riot-ci commented Oct 31, 2022

Murdock results

✔️ PASSED

269b3c9 drivers/slipdev: fix off-by-one error in _recv()

Success Failures Total Runtime
2000 0 2000 06m:07s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

@benpicco benpicco added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Oct 31, 2022
@miri64
Copy link
Member

miri64 commented Oct 31, 2022

alternative to #18229, #18066

So if this one is merged, those other two are not necessary anymore? Seems like the simpler fix!

@miri64
Copy link
Member

miri64 commented Oct 31, 2022

[…], but neither reached consensus.

More like, the only person who seems to care, does not have time to review such large changes ^^".

@maribu maribu added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Nov 1, 2022
@maribu maribu enabled auto-merge November 1, 2022 05:59
@maribu maribu merged commit 3c207a3 into RIOT-OS:master Nov 1, 2022
@maribu
Copy link
Member

maribu commented Nov 1, 2022

We can still have the PR with the chunked ring buffer merged to master. For the release it is convenient to only backport a minimal bug fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants