cpu/esp32: set bootloader XTAL frequency configuration to automatic #18829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: cpu
gschorcht
approved these changes
Nov 1, 2022
gschorcht
added
Type: bug
Murdock results✔️ PASSED b0686ce cpu/esp32: set bootloader XTAL frequency configuration to automatic
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Sets the XTAL frequency configuration of the ESP32 bootloader to automatic (0). Before that, it was fixed/hardcoded to 40 MHz which results in UART output problems with non-40MHz boards such as the one in #18828.
Testing procedure
If you've a board with 26 MHz XTAL crystal at hand, flash and test any shell based application:
make BOARD=esp32-wroom-32 -C tests/shell. If not, all tests should still pass on all ESP32 boards.If everything works, UART will output text normally. Before the PR, rubbish should appear such as in the actual results of #18828.
Issues/PRs references
Fixes #18828.
Follow-up to #13059.