Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18856 lead to huge implementations this does that better a more efficient DIV_ROUND_UINT is not required
Contribution description
this fixes DIV_ROUND
this fixes DIV_ROUND_UP and documents its now reliable behavior
this add DIV_ROUND_INF which round away from 0 (the original intended behavior of DIV_ROUND_UP)
this adds Tests that test the DIV_ROUND* macros with negative inputs
Testing procedure
read, test, run tests/unitest/ core
Issues/PRs references
have a test at
https://godbolt.org/z/bEvT6Wzr9
#18849
#18856
#18853