Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/include: remove kernel_defines.h where not needed #18887

Merged
merged 7 commits into from
Nov 29, 2022
Merged

sys/include: remove kernel_defines.h where not needed #18887

merged 7 commits into from
Nov 29, 2022

Conversation

kfessel
Copy link
Contributor

@kfessel kfessel commented Nov 11, 2022

Contribution description

based of #18882 I cleaned kernel_defines.h from sys/includes and fixed missing includes

Testing procedure

read

Issues/PRs references

#18882 and #18884

@github-actions github-actions bot added Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: LoRa Area: LoRa radio support Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework Area: timers Area: timer subsystems Area: USB Area: Universal Serial Bus labels Nov 11, 2022
@kfessel kfessel changed the title P clean header kerneldef sys/include: remove kernel_defines.h where not needed Nov 11, 2022
@kfessel kfessel added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 11, 2022
@riot-ci
Copy link

riot-ci commented Nov 11, 2022 •
edited
Loading

Murdock results

✔️ PASSED

d301de4 shell/cmds: add missing includes for ARRAY_SIZE

Success Failures Total Runtime
117849 0 117849 02h:28m:59s

Artifacts

@kfessel kfessel force-pushed the p-clean-header-kerneldef branch from 909d825 to b77cc84 Compare November 11, 2022 20:30
@github-actions github-actions bot added the Area: drivers Area: Device drivers label Nov 11, 2022
@benpicco
Copy link
Contributor

This can be rebased now

@kfessel kfessel force-pushed the p-clean-header-kerneldef branch from 589933c to d301de4 Compare November 22, 2022 12:41
@github-actions github-actions bot removed the Area: core Area: RIOT kernel. Handle PRs marked with this with care! label Nov 22, 2022
@benpicco benpicco merged commit 388f9a2 into RIOT-OS:master Nov 29, 2022
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: LoRa Area: LoRa radio support Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework Area: timers Area: timer subsystems Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2023.01
Development

Successfully merging this pull request may close these issues.
4 participants
@kfessel @riot-ci @benpicco @kaspar030