Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/shell: drop ping6 alias #18931

Merged
merged 1 commit into from
Nov 19, 2022
Merged

sys/shell: drop ping6 alias #18931

merged 1 commit into from
Nov 19, 2022

Conversation

benpicco
Copy link
Contributor

Contribution description

We don't need two names for the same command, ping is enough.

Testing procedure

Issues/PRs references

@benpicco
sys/shell: drop ping6 alias
b5339c6 
We don't need two names for the same command, ping is enough.
@benpicco benpicco requested review from maribu and miri64 November 18, 2022 11:55
@github-actions github-actions bot added the Area: sys Area: System label Nov 18, 2022
@benpicco benpicco added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Nov 18, 2022
@benpicco benpicco requested a review from kaspar030 November 18, 2022 11:56
maribu
maribu approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I assume that any host side scripts and scripting abstractions (looking at riotctrl) have been updated long ago? Otherwise we may have to go through deprecation.

@benpicco
Copy link
Contributor Author

AFAIK the only holdout is RIOT-OS/Tutorials#82 but that repo appears to be unmaintained.

@miri64
Copy link
Member

miri64 commented Nov 18, 2022

AFAIK the only holdout is RIOT-OS/Tutorials#82 but that repo appears to be unmaintained.

We still use it for teaching. So please, if you can, provide a PR.

@benpicco
Copy link
Contributor Author

I already did so in May - you just quoted it 😉

@miri64
Copy link
Member

miri64 commented Nov 18, 2022

Thanks! 😵‍💫

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 18, 2022
@riot-ci
Copy link

riot-ci commented Nov 19, 2022

Murdock results

✔️ PASSED

b5339c6 sys/shell: drop ping6 alias

Success Failures Total Runtime
117848 0 117848 02h:28m:06s

Artifacts

@miri64 miri64 merged commit 3e68923 into RIOT-OS:master Nov 19, 2022
@benpicco benpicco deleted the ping6-purge branch November 19, 2022 14:46
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@miri64 miri64 Awaiting requested review from miri64

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2023.01
Development

Successfully merging this pull request may close these issues.
5 participants
@benpicco @miri64 @riot-ci @maribu @kaspar030