Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/nucleo-l496zg: add ADC support #18940

Merged
merged 2 commits into from
Nov 23, 2022
Merged

boards/nucleo-l496zg: add ADC support #18940

merged 2 commits into from
Nov 23, 2022

Conversation

krzysztof-cabaj
Copy link
Contributor

Contribution description

This PR adds to the Nucleo-l496zg ADC configuration.

Testing procedure

Flash the board using tests/periph_adc program. Check if measured values changes when A0-A5 pins are
connected to the 3,3V, GND or to the potentiometer.

Issues/PRs references

None

@github-actions github-actions bot added Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Nov 21, 2022
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 21, 2022
@krzysztof-cabaj
Copy link
Contributor Author

Hmm ... are there some problems with Murdock?

-- Building PR #18940 https://github.com/RIOT-OS/RIOT/pull/18940 head: d557f1201e38abc7c4bea9e9652b623c69163030...
usage: reporter.py [-h] queue job_uid job_token
reporter.py: error: the following arguments are required: job_token

and stale at state checking cluster.

@maribu
Copy link
Member

maribu commented Nov 21, 2022

Sorry for the inconvenience. It was a human error in administration. The job is already re-queued and should now run as expected.

maribu
maribu approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thx :)

I didn't do any testing but I double checked that the pins indeed have the alternate function given in the comment according to the data sheet and that the comment matches the .dev and .chan params.

Please note the inline comment. If you take the suggestion, please squash right away.

boards/nucleo-l496zg/include/periph_conf.h Outdated Show resolved Hide resolved
@maribu maribu enabled auto-merge November 21, 2022 13:00
auto-merge was automatically disabled November 21, 2022 13:07

Head branch was pushed to by a user without write access

@riot-ci
Copy link

riot-ci commented Nov 21, 2022 •
edited
Loading

Murdock results

✔️ PASSED

c7cd72c boards/nucleo-l496zg: add ADC support

Success Failures Total Runtime
117854 0 117854 02h:25m:27s

Artifacts

@krzysztof-cabaj
Copy link
Contributor Author

krzysztof-cabaj commented Nov 21, 2022 •
edited
Loading

There are still some problems with Murdock - it seems that disk is full.

docker: Error response from daemon: write /var/lib/containerd/io.containerd.metadata.v1.bolt/meta.db: no space left on device: unknown.

Update.
Murdock starts around 20:00.

@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 22, 2022
@benpicco benpicco merged commit 86d72c7 into RIOT-OS:master Nov 23, 2022
@krzysztof-cabaj
Copy link
Contributor Author

@maribu Thank you for a few re-queening of this PR - the forth one ends with success without problems with Murdock.

@benpicco Thanks for merging.

@krzysztof-cabaj krzysztof-cabaj mentioned this pull request Nov 28, 2022
Merged
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@DipSwitch DipSwitch Awaiting requested review from DipSwitch

@vincent-d vincent-d Awaiting requested review from vincent-d vincent-d is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Milestone
Release 2023.01
Development

Successfully merging this pull request may close these issues.
5 participants
@krzysztof-cabaj @maribu @riot-ci @benpicco @kaspar030