Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/nrf5x_common/periph_timer: fix spurious IRQs #18970

Merged
merged 1 commit into from
Nov 25, 2022
Merged

cpu/nrf5x_common/periph_timer: fix spurious IRQs #18970

merged 1 commit into from
Nov 25, 2022

Conversation

maribu
Copy link
Member

@maribu maribu commented Nov 24, 2022

Contribution description

As the title says

Testing procedure

The test in #18963 should now pass

Issues/PRs references

#18963

@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Nov 24, 2022
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Nov 24, 2022
kaspar030
kaspar030 approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@kaspar030 kaspar030 enabled auto-merge November 24, 2022 22:00
@riot-ci
Copy link

riot-ci commented Nov 25, 2022 •
edited
Loading

Murdock results

✔️ PASSED

fbd7b77 cpu/nrf5x_common/periph_timer: fix spurious IRQs

Success Failures Total Runtime
1 0 1 01m:07s

Artifacts

@maribu
Copy link
Member Author

maribu commented Nov 25, 2022

The single CI failure was on native:

-- running on worker comsys thread 1, build number 2488.
make: Entering directory '/tmp/dwq.0.5191207894204415/945d734232500d3d47e2ddb89f802ef5/examples/suit_update'
# Reset package to checkout state.
rm -rf /tmp/dwq.0.5191207894204415/945d734232500d3d47e2ddb89f802ef5/build/pkg/c25519
rm -rf /tmp/dwq.0.5191207894204415/945d734232500d3d47e2ddb89f802ef5/build/pkg-build/libcose
rm -rf /tmp/dwq.0.5191207894204415/945d734232500d3d47e2ddb89f802ef5/build/pkg-build/littlefs2
rm -rf /tmp/dwq.0.5191207894204415/945d734232500d3d47e2ddb89f802ef5/build/pkg-build/nanocbor
make: Leaving directory '/tmp/dwq.0.5191207894204415/945d734232500d3d47e2ddb89f802ef5/examples/suit_update'
make: Entering directory '/tmp/dwq.0.5191207894204415/945d734232500d3d47e2ddb89f802ef5/examples/suit_update'
make: *** No rule to make target '/tmp/dwq.0.5191207894204415/945d734232500d3d47e2ddb89f802ef5/examples/suit_update/bin/native/suit_update/fw.1669339261.bin', needed by 'link'.  Stop.
[...]

This is obviously unrelated. I'm skipping build tests now and call the last run a pass.

@maribu maribu added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 25, 2022
@kaspar030 kaspar030 merged commit f1a8e1f into RIOT-OS:master Nov 25, 2022
@maribu maribu deleted the cpu/nrf5x_common/periph_timer/fix_spurious_irqs branch November 25, 2022 07:28
@maribu
Copy link
Member Author

maribu commented Nov 25, 2022

Thx :)

@maribu maribu mentioned this pull request Nov 25, 2022
Merged
@maribu
Copy link
Member Author

maribu commented Nov 25, 2022

Backport provided in #18974

@maribu maribu mentioned this pull request Nov 25, 2022
Open
20 tasks
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Platform: ARM Platform: This PR/issue effects ARM-based platforms Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2023.01
Development

Successfully merging this pull request may close these issues.
3 participants
@maribu @riot-ci @kaspar030