Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/esp{32,8266}/periph_timer: allow changing callback or freq #18971

Merged
merged 2 commits into from
Nov 25, 2022
Merged

cpu/esp{32,8266}/periph_timer: allow changing callback or freq #18971

merged 2 commits into from
Nov 25, 2022

Conversation

maribu
Copy link
Member

@maribu maribu commented Nov 24, 2022

Contribution description

Allow multiple calls to timer_init(), as this is the only way to change the timer frequency or the callback function.

Testing procedure

The test in #18963 should now pass.

Issues/PRs references

#18963

@maribu
cpu/esp32/periph_timer: allow changing callback or freq
e8fd655 
Allow multiple calls to timer_init(), as this is the only way to
change the timer frequency or the callback function.
@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Nov 24, 2022
@maribu maribu requested a review from gschorcht as a code owner November 24, 2022 21:39
@maribu
cpu/esp8266/periph_timer: allow changing callback or freq
03b7fe8 
Allow multiple calls to timer_init(), as this is the only way to
change the timer frequency or the callback function.
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Nov 24, 2022
@maribu maribu enabled auto-merge November 25, 2022 06:38
@riot-ci
Copy link

riot-ci commented Nov 25, 2022

Murdock results

✔️ PASSED

03b7fe8 cpu/esp8266/periph_timer: allow changing callback or freq

Success Failures Total Runtime
117858 0 117858 01h:56m:31s

Artifacts

@maribu maribu merged commit c89c75d into RIOT-OS:master Nov 25, 2022
@maribu maribu mentioned this pull request Nov 25, 2022
Merged
@maribu
Copy link
Member Author

maribu commented Nov 25, 2022

Backport provided in #18973

@maribu maribu deleted the cpu/esp branch November 25, 2022 07:26
@maribu
Copy link
Member Author

maribu commented Nov 25, 2022

Thx :)

@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschorcht gschorcht gschorcht approved these changes

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2023.01
Development

Successfully merging this pull request may close these issues.
4 participants
@maribu @riot-ci @gschorcht @kaspar030