dist/tools/usb-serial: fix exception on missing entries #19011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some TTY interfaces no DB entry exists, which is reflected by having a `None` in `tty[key]`. Trying to match a regex against `None` in turn resulted then in an exception. This fixes the issue by treating a filter applied on a non-existing entry as not matching.
maribu
added
Type: bug
1 task
maribu
added
the
CI: ready for build
benpicco
approved these changes
Dec 5, 2022
benpicco
added
the
CI: skip compile test
|
Thx :) |
|
Backport provided in #19018 |
bors bot
added a commit
that referenced
this pull request
Dec 11, 2022
19012: boards/arduino-mega2560: add TTY_BOARD_FILTER r=gschorcht a=maribu ### Contribution description This allows automatically selecting TTY actually belonging to an Arduino Mega2560 if `MOST_RECENT_PORT=1` is set. ### Testing procedure ``` make BOARD=arduino-mega2560 MOST_RECENT_PORT=1 -C examples/default flash term ``` Should automatically select the TTY of the most recently connected Arduino Mega2560, even if a board of a different type is connect more recently. ### Issues/PRs references - [x] depends on (and includes) #19011 Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de> Co-authored-by: Marian Buschsieweke <maribu@users.noreply.github.com>
bors bot
added a commit
that referenced
this pull request
Dec 11, 2022
19012: boards/arduino-mega2560: add TTY_BOARD_FILTER r=gschorcht a=maribu ### Contribution description This allows automatically selecting TTY actually belonging to an Arduino Mega2560 if `MOST_RECENT_PORT=1` is set. ### Testing procedure ``` make BOARD=arduino-mega2560 MOST_RECENT_PORT=1 -C examples/default flash term ``` Should automatically select the TTY of the most recently connected Arduino Mega2560, even if a board of a different type is connect more recently. ### Issues/PRs references - [x] depends on (and includes) #19011 Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
For some TTY interfaces no DB entry exists, which is reflected by having a
Noneintty[key]. Trying to match a regex againstNonein turn resulted then in an exception.This fixes the issue by treating a filter applied on a non-existing entry as not matching.
Testing procedure
With the following TTYs attached:
In
masterWith this PR:
Issues/PRs references
None