cpu/sam0_common/periph_timer: implement timer_set() #19036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fallback implementation of timer_set() in `drivers/periph_common` is known to fail on short relative sets. This adds a robust implementation.
maribu
added
Type: bug
github-actions
bot
added
the
Platform: ARM
maribu
commented
Dec 9, 2022
| * afterwards. We add one to risk rather jumping over one tick | ||
| * rather than having the clock going backwards by one time */ | ||
| unsigned now = timer_read(tim); | ||
| timer_stop(tim); |
There was a problem hiding this comment.
TODO: Does this have nasty side affects like loosing the IRQ mask or the CC reg of the other channel?
There was a problem hiding this comment.
Is this TODO required to be done for this PR ?
If not, I can have a look at it.
There was a problem hiding this comment.
Ideally I would just extend the periph_timer test so that such side effects would be directly detected. I'll try to allocate some time for that, but currently my work load is quite high :-/
There was a problem hiding this comment.
I feel your pain, I'm somehow in the same position :)
So should we wait a bit for this PR ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The fallback implementation of timer_set() in
drivers/periph_commonis known to fail on short relative sets. This adds a robust implementation.Testing procedure
Run
tests/periph_timer_short_relative_setat least a few dozen times (or use #19030 to have a few dozen repetitions of the test case in a single run of the test application). It should now succeed.Issues/PRs references
None