boards/seeedstudio-gd32: fix HXTAL clock in Kconfig #19129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschorcht
requested review from
leandrolanzieri,
jia200x and
MrKevinWeiss
as code owners
github-actions
bot
added
Area: boards
gschorcht
added
Type: bug
aabadie
approved these changes
Jan 11, 2023
This was referenced Jan 11, 2023
|
bors merge (backport got already |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
bors merge |
|
Build succeeded: |
|
Thanks for reviewing and merging. |
bors bot
added a commit
that referenced
this pull request
Jan 12, 2023
19131: boards/seeedstudio-gd32: fix HXTAL clock in Kconfig [backport 2023.01] r=aabadie a=gschorcht # Backport of #19129 ### Contribution description This PR fixes the wrong default value of `CLOCK_HXTAL` in Kconfig introduced with PR #19109. It was accidentally set to the default value of 80 MHz instead of 8 MHz. ### Testing procedure ``` python3 dist/tools/compile_test/compile_like_murdock.py -a tests/shell -b seeedstudio-gd32 -j8 ``` Without the PR the command gives: ``` tests/shell seeedstudio-gd32 FAIL: Kconfig hash mismatch ``` WIth the PR the compile test should pass: ``` tests/shell seeedstudio-gd32 PASS ``` ### Issues/PRs references Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
gschorcht
deleted the
boards/seeedstudio-gd32/fix_hxtal_clock_in_kconfig
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixes the wrong default value of
CLOCK_HXTALin Kconfig introduced with PR #19109. It was accidentally set to the default value of 80 MHz instead of 8 MHz.Testing procedure
Without the PR the command gives:
WIth the PR the compile test should pass:
Issues/PRs references