Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toolchain/gnu.inc.mk: don't check version if CC is not installed #19137

Merged
merged 1 commit into from
Jan 13, 2023
Merged

toolchain/gnu.inc.mk: don't check version if CC is not installed #19137

merged 1 commit into from
Jan 13, 2023

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jan 13, 2023

Contribution description

With b30efee a warning was introduced when using make term without the proper toolchain installed (e.g. when using BUILD_IN_DOCKER, but term outside of the docker). This removes this warning.

Testing procedure

Run make term for a board where you do not have the toolchain installed. Output such as

/bin/sh: line 1: xtensa-esp32-elf-gcc: command not found

should disappear with this PR.

Issues/PRs references

Fixes a minor issue introduced in #18935.

@miri64
toolchain/gnu.inc.mk: don't check version if CC is not installed
212933f 
With b30efee a warning was introduced when using `make term` without
the proper toolchain installed (e.g. when using BUILD_IN_DOCKER, but
`term` outside of the docker). This removes this warning
@miri64 miri64 added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Jan 13, 2023
@miri64 miri64 requested a review from benpicco January 13, 2023 10:53
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 13, 2023
@github-actions github-actions bot added Area: build system Area: Build system Area: toolchain Area: toolchains; everything related to compilation, libc, linking, … labels Jan 13, 2023
@kaspar030 kaspar030 added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Jan 13, 2023
kaspar030
kaspar030 approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 13, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@bors
Copy link
Contributor

bors bot commented Jan 13, 2023

👎 Rejected by PR status

@maribu
Copy link
Member

maribu commented Jan 13, 2023

bors retry

@bors
Copy link
Contributor

bors bot commented Jan 13, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@riot-ci
Copy link

riot-ci commented Jan 13, 2023

Murdock results

✔️ PASSED

212933f toolchain/gnu.inc.mk: don't check version if CC is not installed

Artifacts

@maribu
Copy link
Member

maribu commented Jan 13, 2023

bors merge

bors bot added a commit that referenced this pull request Jan 13, 2023
@bors @miri64
Merge #19137
82d516f 
19137: toolchain/gnu.inc.mk: don't check version if CC is not installed r=maribu a=miri64





Co-authored-by: Martine Lenders <m.lenders@fu-berlin.de>
@kaspar030
Copy link
Contributor

bors cancel
bors merge

@bors
Copy link
Contributor

bors bot commented Jan 13, 2023

Canceled.

@bors
Copy link
Contributor

bors bot commented Jan 13, 2023

Build succeeded:

@bors bors bot merged commit 9d8fdd3 into RIOT-OS:master Jan 13, 2023
@maribu maribu mentioned this pull request Jan 15, 2023
Merged
@maribu
Copy link
Member

maribu commented Jan 15, 2023

Backport provided in #19152

bors bot added a commit that referenced this pull request Jan 16, 2023
@bors @miri64
Merge #19152
d4020b9 
19152: toolchain/gnu.inc.mk: don't check version if CC is not installed [backport 2023.01] r=kaspar030 a=maribu

# Backport of #19137





Co-authored-by: Martine Lenders <m.lenders@fu-berlin.de>
@jia200x jia200x added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@benpicco benpicco Awaiting requested review from benpicco

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: toolchain Area: toolchains; everything related to compilation, libc, linking, … CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
No open projects
@kaspar030's 2023.01 TODO board
Status: Backport waiting for CI
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
5 participants
@miri64 @maribu @riot-ci @kaspar030 @jia200x