cpu/gd32v: move board dependent RTT configs to board config #19211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: boards
gschorcht
added
Type: bug
maribu
approved these changes
Jan 29, 2023
github-actions
bot
added
Area: tools
gschorcht
force-pushed
the
cpu/gd32v/fix_rtt_frequency
branch
from
5589e86 to
993a65e
Compare
|
@maribu I had to add RTT defines to |
|
bors merge |
|
Build succeeded: |
|
@maribu Thanks for reviewing and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixes the problem that the RTT frequency is defined to be 40.0 kHz instead of 32.768 kHz if
TEST_KCONFIG=1is not defined.The problem was caused by the order in which the headers were included. In
cpu/gd32v/include/periph_cpu.hthe RTT frequency was defined to be 32.768 kHz or 40.0 kHz, depending on theCONFIG_BOARD_HAS_LXTALconfiguration of the board. IfTEST_KCONFIG=1is used, it is defined inautoconfig.hand is always known, but withoutTEST_KCONFIG=1it is defined in theperiph_conf.hof the board. Ifperiph_cpu.his included but notperiph_conf.h,CONFIG_BOARD_HAS_LXTALis not defined withoutTEST_KCONFIG=1and the RTT frequency is defined to be 40.0 kHz.The solution is to move board dependent RTT configurations to
periph_common.conf.Testing procedure
should still work.
Issues/PRs references