-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/gd32v: add periph_gpio_ll and periph_gpio_ll_irq support #19243
Conversation
8ecdca6
to
41289cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx :) Code looks good and the app should catch any bugs. Please squash right away.
41289cb
to
0561e99
Compare
bors merge |
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
19243: cpu/gd32v: add periph_gpio_ll and periph_gpio_ll_irq support r=maribu a=gschorcht ### Contribution description This PR provides the `periph_gpio_ll` and `periph_gpio_ll_irq` support for GD32VF103. Level triggered interrupts are emulated. `periph_gpio_ll_irq` could be split off from this PR as a separate PR if necessary. ### Testing procedure Use any GD32V board and connect PA0 -> PB0 and PA1 -> PB1 where PA is the output port and PB the input port. With these connections `tests/periph_gpio_ll` should work. ``` BOARD=sipeed-longan-nano make -j8 -C tests/periph_gpio_ll flash term ``` If necessary, change the input and output pins by setting the environment variables and connect the corresponding pins, for example for `seeedstudio-gd32` PA1 -> PB8 and PA8 -> PB9: ``` PIN_OUT_0=1 PIN_OUT_1=8 PIN_IN_0=8 PIN_IN_1=9 BOARD=seedstudio-gd32 make -j8 -C tests/periph_gpio_ll flash term ``` ### Issues/PRs references Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
manual merge train packing 🚂 🚋 🚋 bors retry |
Already running a review |
bors cancel Come on, let's get two PRs in the merge train :) |
Canceled. |
19243: cpu/gd32v: add periph_gpio_ll and periph_gpio_ll_irq support r=maribu a=gschorcht ### Contribution description This PR provides the `periph_gpio_ll` and `periph_gpio_ll_irq` support for GD32VF103. Level triggered interrupts are emulated. `periph_gpio_ll_irq` could be split off from this PR as a separate PR if necessary. ### Testing procedure Use any GD32V board and connect PA0 -> PB0 and PA1 -> PB1 where PA is the output port and PB the input port. With these connections `tests/periph_gpio_ll` should work. ``` BOARD=sipeed-longan-nano make -j8 -C tests/periph_gpio_ll flash term ``` If necessary, change the input and output pins by setting the environment variables and connect the corresponding pins, for example for `seeedstudio-gd32` PA1 -> PB8 and PA8 -> PB9: ``` PIN_OUT_0=1 PIN_OUT_1=8 PIN_IN_0=8 PIN_IN_1=9 BOARD=seedstudio-gd32 make -j8 -C tests/periph_gpio_ll flash term ``` ### Issues/PRs references 19257: pkg/lvgl: bump to 8.3.5 r=maribu a=aabadie Co-authored-by: Gunar Schorcht <gunar@schorcht.net> Co-authored-by: Alexandre Abadie <alexandre.abadie@inria.fr>
Build failed (retrying...): |
Canceled. |
Cool, Rust catched a problem in |
bors merge |
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
bors merge |
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
bors merge |
Build succeeded: |
Thanks for reviewing. |
Contribution description
This PR provides the
periph_gpio_ll
andperiph_gpio_ll_irq
support for GD32VF103. Level triggered interrupts are emulated.periph_gpio_ll_irq
could be split off from this PR as a separate PR if necessary.Testing procedure
Use any GD32V board and connect PA0 -> PB0 and PA1 -> PB1 where PA is the output port and PB the input port. With these connections
tests/periph_gpio_ll
should work.If necessary, change the input and output pins by setting the environment variables and connect the corresponding pins, for example for
seeedstudio-gd32
PA1 -> PB8 and PA8 -> PB9:Issues/PRs references