tests/driver_dac_dds: fix output of sine and saw functions #19251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
requested review from
smlng,
leandrolanzieri,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
benpicco
added
Type: bug
gschorcht
approved these changes
Feb 6, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Feb 6, 2023
17045: sys/coding: add XOR based coding module r=benpicco a=benpicco 19248: cpu/gd32v: add periph_dac support r=benpicco a=gschorcht ### Contribution description This PR provides the `periph_dac` support for GD32VF103. ### Testing procedure `tests/periph_dac` should work on `sipeed-longan-nano` port on PA4 and PA5. ### Issues/PRs references 19251: tests/driver_dac_dds: fix output of sine and saw functions r=benpicco a=benpicco Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com> Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Feb 7, 2023
17045: sys/coding: add XOR based coding module r=benpicco a=benpicco 19251: tests/driver_dac_dds: fix output of sine and saw functions r=benpicco a=benpicco 19254: cpu/gd32v: add periph_rtc_mem support r=benpicco a=gschorcht ### Contribution description This PR provides the `periph_rtc_mem` support for GD32VF103. A modified version of this driver could also be used for STM32F1. ### Testing procedure `tests/periph_rtt` should work on any GD32V board, for example: ``` BOARD=sipeed-longan-nano make -C tests/periph_rtt flash ``` ``` Help: Press s to start test, r to print it is ready START main(): This is RIOT! (Version: 2023.04-devel-319-gebc86-cpu/gd32v/periph_rtc_mem) RIOT RTT low-level driver test RTT configuration: RTT_MAX_VALUE: 0xffffffff RTT_FREQUENCY: 32768 Testing the tick conversion Trying to convert 1 to seconds and back Trying to convert 256 to seconds and back Trying to convert 65536 to seconds and back Trying to convert 16777216 to seconds and back Trying to convert 2147483648 to seconds and back All ok Initializing the RTT driver RTC mem OK This test will now display 'Hello' every 5 seconds RTT now: 1 Setting initial alarm to now + 5 s (163841) rtt_get_alarm() PASSED RTC mem OK ``` ### Issues/PRs references Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com> Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The
sineandsawcommands have a bug that can lead to either distorted (sine) or no (saw) output.Testing procedure
sine in master
sine with this PR
saw with this PR
Issues/PRs references