-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/tinydtls: allow build for AVR #19346
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Mar 4, 2023
benpicco
added
CI: no fast fail
don't abort PR build after first error
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
and removed
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Mar 4, 2023
Looks like only some Makefile.ci updstes are needed to get this in |
maribu
approved these changes
Mar 4, 2023
bors try |
tryBuild failed: |
benpicco
requested review from
miri64,
smlng,
aabadie,
MichelRottleuthner,
fjmolinas,
kYc0o and
nandojve
as code owners
April 26, 2023 00:07
github-actions
bot
added
Area: cpu
Area: CPU/MCU ports
Area: examples
Area: Example Applications
Area: tests
Area: tests and testing framework
Platform: AVR
Platform: This PR/issue effects AVR-based platforms
labels
Apr 26, 2023
maribu
approved these changes
Apr 26, 2023
benpicco
force-pushed
the
pkg/tinydtls-avr
branch
from
April 26, 2023 08:31
2b27011
to
824d2f8
Compare
bors merge |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: cpu
Area: CPU/MCU ports
Area: examples
Area: Example Applications
Area: pkg
Area: External package ports
Area: tests
Area: tests and testing framework
CI: no fast fail
don't abort PR build after first error
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Platform: AVR
Platform: This PR/issue effects AVR-based platforms
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
tinyDTLS builds and works just fine on AVR, we only have to disable the custom logging functions as those will try to call
printf()
with non-literal strings. (We don't even call them, but they get built anyway)Testing procedure
I used
tests/nanocoap_cli
for testing. AsTHREAD_STACKSIZE_DEFAULT
is lower on AVR we have to bump the main stack size here:I ran a border router on
samr21-xpro
withand
examples/gcoap_dtls
onnative
on thetap1
port. I then connected from theavr-rss2
to thenative
instance via thesamr21-xpro
border router:Issues/PRs references
upstream PR to no build custom logging functions: eclipse/tinydtls#189