Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sam0/usbdev: partial revert of #17086 #19384

Merged
merged 1 commit into from
Mar 13, 2023
Merged

sam0/usbdev: partial revert of #17086 #19384

merged 1 commit into from
Mar 13, 2023

Conversation

dylad
Copy link
Member

@dylad dylad commented Mar 13, 2023

Contribution description

Reverting theses changes from #17086 because it breaks SAM0 usbdev in master.
The idea was to following the USB spec but for not obvious reason yet, it doesn't work as intended.
So revert these changes so usbdev works again on master.
We will try to figured out what's wrong later.

Testing procedure

Test any usbus related test application w/ a SAM0-based board.

Issues/PRs references

See discussion in #17086

@dylad
sam0/usbdev: partial revert of RIOT-OS#17086
b4b41bc 
Reverting theses changes from RIOT-OS#17086 because it breaks SAM0 usbdev in master

Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
@dylad dylad requested review from benpicco and keestux as code owners March 13, 2023 12:54
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Mar 13, 2023
@dylad dylad mentioned this pull request Mar 13, 2023
Merged
gschorcht
gschorcht approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@gschorcht gschorcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments in PR #19384 why the changes are reverted for now.

@gschorcht
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 13, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@dylad dylad added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 13, 2023
@riot-ci
Copy link

riot-ci commented Mar 13, 2023

Murdock results

✔️ PASSED

b4b41bc sam0/usbdev: partial revert of #17086

Success Failures Total Runtime
6882 0 6882 09m:52s

Artifacts

@bors
Copy link
Contributor

bors bot commented Mar 13, 2023

Build succeeded:

@bors bors bot merged commit 993e539 into RIOT-OS:master Mar 13, 2023
@dylad dylad deleted the pr/sam0/usbdev/revert_dgtl_bits branch March 13, 2023 15:59
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschorcht gschorcht gschorcht approved these changes

@benpicco benpicco Awaiting requested review from benpicco benpicco is a code owner

@keestux keestux Awaiting requested review from keestux keestux is a code owner

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
4 participants
@dylad @gschorcht @riot-ci @MrKevinWeiss