Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/qcbor: bump to v1.2 #19494

Merged
merged 2 commits into from
Apr 22, 2023
Merged

pkg/qcbor: bump to v1.2 #19494

merged 2 commits into from
Apr 22, 2023

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Apr 22, 2023

Contribution description

The current version of this package a master commit from 2020 while version 1.2 was release in January 2023. This PR bumps to this version and extend a bit the documentation with some notes on how to disable some features to shave some code. By default, the new version adds ~400B of ROM but when disabling some features it can be less than the version in master.

Testing procedure

  • Green CI

Issues/PRs references

None

@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 22, 2023
@aabadie aabadie marked this pull request as ready for review April 22, 2023 16:26
@github-actions github-actions bot added Area: doc Area: Documentation Area: pkg Area: External package ports labels Apr 22, 2023
@riot-ci
Copy link

riot-ci commented Apr 22, 2023

Murdock results

✔️ PASSED

bd3e6a2 pkg/qcbor: document how to disable features using CFLAGS

Success Failures Total Runtime
6882 0 6882 10m:19s

Artifacts

Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 22, 2023

Build succeeded:

@bors bors bot merged commit bd295b0 into RIOT-OS:master Apr 22, 2023
@aabadie aabadie deleted the pr/pkg/qcbor_v1.2 branch April 27, 2023 13:20
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants