boards/rpi-pico: specify needed args when using jlink flasher #19537
Conversation
dylad
added
the
CI: ready for build
boards/rpi-pico/Makefile.include
Outdated
|
|
||
| ifeq ($(PROGRAMMER),jlink) | ||
| JLINK_DEVICE = RP2040_M0_0 | ||
| FLASHFILE = $(HEXFILE) |
There was a problem hiding this comment.
Funny, yesterday there was some discussion in matrix and there seemed to be a consensus to prefer ELF files for flashing unless there is a reason against ELF files. Admittedly, only few actively participated in the discussion, though.
But if the ELF file works equally well, I'd personally prefer to stick with the ELF file for flashing.
There was a problem hiding this comment.
Yup, especially because creating a .hex is an extra step (that takes time, ...)
There was a problem hiding this comment.
That's because of this discussion that I think about it. But I don't have strong opinion over .elf vs .hex. I wanted to use J-link probe for sometimes now with this board so it ease debugging when working on new peripheral drivers.
I can confirm that it works too with .elf file so I'll update this PR.
Signed-off-by: dylad <dylan.laduranty@mesotic.com>
dylad
force-pushed
the
boards/rpi-pico/allow_jlink_flasher
branch
from
a039dac to
bd5cff5
Compare
|
|
||
| ifeq ($(PROGRAMMER),jlink) | ||
| JLINK_DEVICE = RP2040_M0_0 | ||
| FLASHFILE = $(ELFFILE) |
There was a problem hiding this comment.
| FLASHFILE = $(ELFFILE) |
I think it should even work like this, as the ELF file is the default flash file anyway. Please squash / amend directly.
There was a problem hiding this comment.
Hmmm, I share some doubts here. When I played with J-link before this PR, it defaults to .bin file and flashing doesn't work. (Because I didn't provide the flash memory offset I guess) so I add to pass FLASHFILE manually during the make flash command.
But maybe I'm wrong here. I'll try again tonight. I left my rpi-pico board at home.
There was a problem hiding this comment.
This should be the culprit.
There was a problem hiding this comment.
OK, let's merge this as is. I can rebase #19541 on top of that and drop this line again there, as then the ELF file would indeed be the default.
There was a problem hiding this comment.
As you wish. I've removed the waiting for PRs label.
I'll also try to test #19541 to see if there is any breakage.
|
Let's merge #19541 first then. |
dylad
added
State: waiting for other PR
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
Thanks for the review! |
Contribution description
This PR adds the jlink device variable and use hexfile to flash application with a jlink probe.
Testing procedure
Attach a
jlinkprobe to SWD pins.Try to flash any app with
jlinkPROGRAMMER=jlink make BOARD=rpi-pico -C examples/blinky flashIssues/PRs references
None.