build-system: Allow out of tree BUILD_DIR #19600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace all users of `$(RIOTBASE)/build` with the already present `$(BUILD_DIR)` variable - Replace all users of `$(BUILD_DIR)/pkg` with the already present `$(PKGDIRBASE)` variable - Create a `CACHEDIR.TAG` file in the `$(BUILD_DIR)`
maribu
added
Type: enhancement
maribu
requested review from
leandrolanzieri,
jia200x,
MrKevinWeiss,
smlng,
aabadie,
MichelRottleuthner,
fjmolinas,
DipSwitch and
vincent-d
as code owners
github-actions
bot
added
Area: cpu
chrysn
approved these changes
May 16, 2023
There was a problem hiding this comment.
LGTM, works as advertised.
Note there's a typo (BUILDDIR instead of BUILD_DIR) in the PR description; not sure whether these are still committed in full text.
To those unfamiliar with the build system it may be surprising that BUILD_DIR is only used for pkg clones (while the actual building still happens in bin/ as usual); that behavior is not changed here.
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
Thx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
$(RIOTBASE)/buildwith the already present$(BUILD_DIR)variable$(BUILD_DIR)/pkgwith the already present$(PKGDIRBASE)variableCACHEDIR.TAGfile in the$(BUILD_DIR)Testing procedure
BUILD_DIR=~/.cache/RIOT make -C tests/pkg/foobarshould work and foobar should be checked out into~/.cache/RIOTrather than into the$(RIOTBASE)/buildCACHEDIR.TAGfile should be created in that directoryIssues/PRs references
None