drivers/at86rf2xx: setting rx timestamp based on symbol counter for ATmega*RFR2 #19605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chudov
requested review from
miri64,
haukepetersen,
PeterKietzmann,
cgundogan,
daniel-k,
jia200x,
smlng,
kYc0o and
maribu
as code owners
github-actions
bot
added
Area: cpu
chudov
force-pushed
the
driver/at86rf2xx_packet_timestamp
branch
3 times, most recently
from
35a6de0 to
595eef4
Compare
benpicco
added
the
CI: ready for build
benpicco
reviewed
May 17, 2023
maribu
reviewed
May 17, 2023
chudov
force-pushed
the
driver/at86rf2xx_packet_timestamp
branch
2 times, most recently
from
ac6a3e7 to
c52f6e7
Compare
Signed-off-by: chudov <chudov@gmail.com>
maribu
approved these changes
May 19, 2023
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The PR adds setting the 802.15.4 packet reception timestamp based on the symbol counter available in ATmega64/128/256RFR2 MCU. The counter restarts every ~19 hours.
To enable the feature the
USEMODULE += gnrc_netif_timestampneeds to be added to a Makefile.Testing procedure
The
tests/net/gnrc_netif_iee802154was updated to check the behavior on real boards.The test was performed on
derfmega256andnrf52840dongleboards:Two commands
txtsnd 4 bcast testissued on nrf52840dongle 10 seconds apart, lead to the following result on thederfmega256:The received packets have
TIMESTAMPflag and the timestamps differ by 10 seconds.The same command issued on derfmega256 board leads to similar printout on
nrf52840dongleboard, but as its driver doesn't have timestamp handling, the packet has noTIMESTAMPflag and the value in the timestamp field is random.