Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys: add Kconfig support for clif #19621

Merged
merged 1 commit into from
May 20, 2023
Merged

sys: add Kconfig support for clif #19621

merged 1 commit into from
May 20, 2023

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented May 19, 2023 •
edited
Loading

Contribution description

This adds Kconfig support for clif module.

Testing procedure

  • Green CI
  • The symbol is available in "make menuconfig"
  • Not sure how this can be tested as no test application other than the unittests is using it directly. The other module that depends on clif is cord_lc but this is not adapted to Kconfig.

Issues/PRs references

#16875

@github-actions github-actions bot added Area: Kconfig Area: Kconfig integration Area: sys Area: System labels May 19, 2023
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 19, 2023
@riot-ci
Copy link

riot-ci commented May 19, 2023

Murdock results

✔️ PASSED

f28d0f1 sys: add Kconfig support for clif

Success Failures Total Runtime
6945 0 6945 10m:28s

Artifacts

MrKevinWeiss
MrKevinWeiss approved these changes May 20, 2023
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough. I wonder if there would be a nice way of adapting kconfig in unittests. I see right now there are some makefile includes that bring in the deps instead of makefile deps.

Future music, for now ACK!

@MrKevinWeiss
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented May 20, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 975f150 into RIOT-OS:master May 20, 2023
@aabadie aabadie deleted the pr/sys/kconfig_clif branch May 20, 2023 12:47
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: Kconfig Area: Kconfig integration Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2023.07
Development

Successfully merging this pull request may close these issues.
4 participants
@aabadie @riot-ci @MrKevinWeiss @benpicco