-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnrc_ipv6_nib: set default RIO preference to zero #19652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NDP_OPT_RI_FLAGS_PRF_NONE
is 10b which is reserved in the RFC, so 0 is definetly better and is the default according to the RFC.
Another NONE in ``gnrc_ipv6_auto_subnets.c`. /* invalidate old prefix in RIO */
tmp = gnrc_ndp_opt_ri_build(&old_pfx, old_pfx_len, 0,
NDP_OPT_RI_FLAGS_PRF_NONE, *ext_opts); |
Linux will ignore RIOs with preference NONE, so set the preference to zero instead.
1ba92c8
to
8966c14
Compare
bors merge |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Contribution description
Linux will ignore RIOs with preference NONE, so set the preference to zero instead.
RIOT currently ignores the preference.
Testing procedure
Linux accepts the route from an upstream RIOT node
Issues/PRs references