Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_ipv6_nib: set default RIO preference to zero #19652

Merged
merged 1 commit into from
May 23, 2023

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented May 23, 2023

Contribution description

Linux will ignore RIOs with preference NONE, so set the preference to zero instead.
RIOT currently ignores the preference.

Testing procedure

Linux accepts the route from an upstream RIOT node

fd00::/32 via fe80::6481:20ff:fef9:b694 dev usb0 proto ra metric 1024 expires 4294451sec pref medium

Issues/PRs references

@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels May 23, 2023
@benpicco benpicco requested a review from fabian18 May 23, 2023 10:56
@benpicco benpicco added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 23, 2023
Copy link
Contributor

@fabian18 fabian18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NDP_OPT_RI_FLAGS_PRF_NONE is 10b which is reserved in the RFC, so 0 is definetly better and is the default according to the RFC.

@fabian18
Copy link
Contributor

Another NONE in ``gnrc_ipv6_auto_subnets.c`.

    /* invalidate old prefix in RIO */
    tmp = gnrc_ndp_opt_ri_build(&old_pfx, old_pfx_len, 0,
                                NDP_OPT_RI_FLAGS_PRF_NONE, *ext_opts);

Linux will ignore RIOs with preference NONE, so set the preference
to zero instead.
@benpicco benpicco force-pushed the gnrc_ipv6_nib-rio_zero branch from 1ba92c8 to 8966c14 Compare May 23, 2023 11:02
@riot-ci
Copy link

riot-ci commented May 23, 2023

Murdock results

✔️ PASSED

8966c14 gnrc_ipv6_nib: set default RIO preference to zero

Success Failures Total Runtime
6946 0 6946 11m:04s

Artifacts

@fabian18
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented May 23, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 4c27aff into RIOT-OS:master May 23, 2023
@benpicco benpicco deleted the gnrc_ipv6_nib-rio_zero branch May 23, 2023 14:43
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants