Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usbus: don't trigger assertion in usbus_urb_submit() #19664

Merged
merged 1 commit into from
May 31, 2023

Conversation

benpicco
Copy link
Contributor

Contribution description

Testing procedure

  • flash tests/sys/usbus_cdc_ecm
  • reboot the host system

On master this assertion will trigger, with this patch the duplicate URB is ignored.

Network operation continues normal:

2023-05-24 18:24:36,366 - INFO # > ping -c 200 ff02::1%8
2023-05-24 18:24:36,367 - INFO # 
2023-05-24 18:24:36,375 - INFO # 12 bytes from fe80::650a:e7fd:8b57:c7e8%8: icmp_seq=0 ttl=64 time=1.639 ms
2023-05-24 18:24:37,375 - INFO # 12 bytes from fe80::650a:e7fd:8b57:c7e8%8: icmp_seq=1 ttl=64 time=1.433 ms
2023-05-24 18:24:38,377 - INFO # 12 bytes from fe80::650a:e7fd:8b57:c7e8%8: icmp_seq=2 ttl=64 time=2.525 ms
2023-05-24 18:24:39,377 - INFO # 12 bytes from fe80::650a:e7fd:8b57:c7e8%8: icmp_seq=3 ttl=64 time=2.372 ms
2023-05-24 18:24:40,378 - INFO # 12 bytes from fe80::650a:e7fd:8b57:c7e8%8: icmp_seq=4 ttl=64 time=2.463 ms
2023-05-24 18:24:41,378 - INFO # 12 bytes from fe80::650a:e7fd:8b57:c7e8%8: icmp_seq=5 ttl=64 time=2.266 ms
# host reboots
2023-05-24 18:25:01,389 - INFO # 12 bytes from fe80::650a:e7fd:8b57:c7e8%8: icmp_seq=25 ttl=64 time=4.084 ms
2023-05-24 18:25:02,387 - INFO # 12 bytes from fe80::650a:e7fd:8b57:c7e8%8: icmp_seq=26 ttl=64 time=1.508 ms
2023-05-24 18:25:03,387 - INFO # 12 bytes from fe80::650a:e7fd:8b57:c7e8%8: icmp_seq=27 ttl=64 time=1.362 ms
2023-05-24 18:25:04,389 - INFO # 12 bytes from fe80::650a:e7fd:8b57:c7e8%8: icmp_seq=28 ttl=64 time=2.511 ms

Issues/PRs references

fixes #19663

@github-actions github-actions bot added Area: sys Area: System Area: USB Area: Universal Serial Bus labels May 24, 2023
@benpicco benpicco added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 24, 2023
@riot-ci
Copy link

riot-ci commented May 24, 2023

Murdock results

✔️ PASSED

153dbd2 usbus: don't trigger assertion in usbus_urb_submit()

Success Failures Total Runtime
6933 0 6933 10m:10s

Artifacts

@maribu
Copy link
Member

maribu commented May 31, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented May 31, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit d742513 into RIOT-OS:master May 31, 2023
@benpicco benpicco deleted the usbus_urb_submit-assert branch May 31, 2023 10:07
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: sys Area: System Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

usbus_cdc_ecm: failed assertion when host reboots
3 participants