Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/build_system_sanity_check: add check to verify test applications are at the right place #19673

Merged

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented May 26, 2023

Contribution description

This is a follow-up of all PRs that moved/grouped test applications into subdirectories, to prevent tests application placed in tests/pkg_<something>, etc.

Testing procedure

  • Green CI
  • There's a REMOVEME commit that should make static tests fail

Issues/PRs references

Follow-up of the many PRs related to tests subdirectories

@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 26, 2023
@github-actions github-actions bot added Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools labels May 26, 2023
@riot-ci
Copy link

riot-ci commented May 26, 2023

Murdock results

✔️ PASSED

7bac10f dist/tools/buildsystem_sanity_check: add check for tests subdirs

Success Failures Total Runtime
1 0 1 01m:09s

Artifacts

@aabadie
Copy link
Contributor Author

aabadie commented May 26, 2023

So the static tests indeed failed because of the REMOVEME commit: https://github.com/RIOT-OS/RIOT/actions/runs/5091586260/jobs/9151804185?pr=19673#step:5:59

@aabadie aabadie force-pushed the pr/tools/build_system_sanity_check_test_dirs branch from 654ae04 to 3a15632 Compare May 26, 2023 13:56
@github-actions github-actions bot removed the Area: tests Area: tests and testing framework label May 26, 2023
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one nit pick found by the CI (see above). Please squash, ACK remains valid

@aabadie aabadie force-pushed the pr/tools/build_system_sanity_check_test_dirs branch from 3a15632 to 7bac10f Compare May 28, 2023 07:43
@maribu
Copy link
Member

maribu commented May 28, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented May 28, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit e690ef4 into RIOT-OS:master May 28, 2023
@aabadie aabadie deleted the pr/tools/build_system_sanity_check_test_dirs branch May 28, 2023 09:56
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants