Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/hih6130: avoid using floats #19695

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Conversation

maribu
Copy link
Member

@maribu maribu commented May 31, 2023

Contribution description

  • avoid using floating point arithmetic
  • use ztimer instead of xtimer
  • use fmt to print fixed point numbers in the test app

Testing procedure

The test app should still work and print plausible data.

Issues/PRs references

#19614

@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers labels May 31, 2023
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label May 31, 2023
@maribu maribu requested a review from jnohlgard May 31, 2023 17:35
@maribu maribu force-pushed the drivers/hih6130 branch from 313e916 to e52254a Compare May 31, 2023 19:51
drivers/hih6130/hih6130.c Outdated Show resolved Hide resolved
@maribu maribu force-pushed the drivers/hih6130 branch from 3e0d76c to 45e6b7e Compare May 31, 2023 21:19
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 1, 2023
@riot-ci
Copy link

riot-ci commented Jun 1, 2023

Murdock results

✔️ PASSED

bb366c4 drivers/hih6130: avoid using floats

Success Failures Total Runtime
6933 0 6933 12m:21s

Artifacts

@benpicco
Copy link
Contributor

benpicco commented Jun 8, 2023

Kconfig needs an update on the test application

@maribu maribu force-pushed the drivers/hih6130 branch from 45e6b7e to bb366c4 Compare June 8, 2023 12:33
@maribu
Copy link
Member Author

maribu commented Jun 8, 2023

bors merge

bors bot added a commit that referenced this pull request Jun 8, 2023
19695: drivers/hih6130: avoid using floats r=maribu a=maribu

### Contribution description

- avoid using floating point arithmetic
- use ztimer instead of xtimer
- use fmt to print fixed point numbers in the test app


19706: boards/olimex-msp430-h2618: add new board r=maribu a=maribu

### Contribution description

This adds support of the Olimex MSP430-H2618 board. This board has plenty of RAM and ROM for an MSP430 board (even more than the z1), but still is easily obtainable.


Co-authored-by: Marian Buschsieweke <marian.buschsieweke@posteo.net>
Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
@bors
Copy link
Contributor

bors bot commented Jun 8, 2023

Build failed (retrying...):

@bors
Copy link
Contributor

bors bot commented Jun 8, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit d7e4f93 into RIOT-OS:master Jun 8, 2023
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
@maribu maribu deleted the drivers/hih6130 branch December 5, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants