-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers/hih6130: avoid using floats #19695
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Area: drivers
Area: Device drivers
labels
May 31, 2023
maribu
requested review from
smlng,
leandrolanzieri,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
May 31, 2023 17:35
19 tasks
kfessel
reviewed
May 31, 2023
kfessel
reviewed
May 31, 2023
benpicco
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Jun 1, 2023
benpicco
approved these changes
Jun 8, 2023
Kconfig needs an update on the test application |
bors merge |
bors bot
added a commit
that referenced
this pull request
Jun 8, 2023
19695: drivers/hih6130: avoid using floats r=maribu a=maribu ### Contribution description - avoid using floating point arithmetic - use ztimer instead of xtimer - use fmt to print fixed point numbers in the test app 19706: boards/olimex-msp430-h2618: add new board r=maribu a=maribu ### Contribution description This adds support of the Olimex MSP430-H2618 board. This board has plenty of RAM and ROM for an MSP430 board (even more than the z1), but still is easily obtainable. Co-authored-by: Marian Buschsieweke <marian.buschsieweke@posteo.net> Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
Build failed (retrying...): |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: drivers
Area: Device drivers
Area: tests
Area: tests and testing framework
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Testing procedure
The test app should still work and print plausible data.
Issues/PRs references
#19614