cpu/sam0_eth: interrupt based link detection/auto-negotiation #19703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: cpu
benpicco
changed the title
maribu
approved these changes
Jun 2, 2023
benpicco
added
the
State: WIP
|
Is it still WIP ? |
|
It is still using the timer rather then the GPIO IRQ |
|
It uses the IRQ, the timer is just a fallback for when it doesn’t work on the first try - not sure why our board is so ' special' there.
|
benpicco
force-pushed
the
cpu/sam0_eth-link
branch
from
3a97148 to
e0d955b
Compare
benpicco
removed
the
State: WIP
benpicco
changed the title
benpicco
added
the
CI: ready for build
benpicco
force-pushed
the
cpu/sam0_eth-link
branch
from
e0d955b to
63d0695
Compare
benpicco
force-pushed
the
cpu/sam0_eth-link
branch
from
3bd9457 to
9d40bd6
Compare
|
bors merge |
|
Build failed: |
|
The usual KConfig forgotten issue 😉 |
benpicco
force-pushed
the
cpu/sam0_eth-link
branch
from
9d40bd6 to
508d64a
Compare
benpicco
requested review from
leandrolanzieri,
jia200x and
MrKevinWeiss
as code owners
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jun 14, 2023
19703: cpu/sam0_eth: interrupt based link detection/auto-negotiation r=benpicco a=benpicco 19724: dist/tools/openocd: add OPENOCD_SERVER_ADDRESS variable r=benpicco a=fabian18 19735: nrf5x_common: Clear I2C periph shorts r=benpicco a=bergzand ### Contribution description The I2C peripheral's shortcuts are used with the read and write register to automatically stop the I2C transaction or to continue with the next stage. With simple I2C read and write bytes these shorts are not used, but are also not cleared by the function in all cases, causing it to use the shortcut configuration set by a previous function call. This patch ensures that the shorts are always set by the read and write functions ### Testing procedure Should be possible to spot with a logic analyzer and the I2C periph test. Maybe the HIL test can also detect it :) ### Issues/PRs references None Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com> Co-authored-by: Fabian Hüßler <fabian.huessler@ml-pa.com> Co-authored-by: Koen Zandberg <koen@bergzand.net>
|
Build failed (retrying...): |
benpicco
force-pushed
the
cpu/sam0_eth-link
branch
from
508d64a to
2a255ff
Compare
|
Canceled. |
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The PHY interrupt line is connected to the MCU, so we can just generate a GPIO interrupt when a PHY event orrurs.
This allows us to have
LINK_UP/LINK_DOWNevents which are needed to start / stop sending router solicitations.We can also use the result of the auto-negotiation process to configure the MAC accordingly.
There is a bit of a hack inside: When we have an auto-negotiation capable link partner, but auto-negotiation fails after a timeout, we just re-start the auto-negotiation process.
This is not needed on
same54-xprowhere auto-negotiation always works on the first try, but with our custom board, this is not always the case - it's still unclear as to why, but the link is stable afterwards and we don't have any packet loss.So Having this added robustness is IMHO fine.
Testing procedure
ifconfigshould now show the real link status.When you start the board with the Ethernet cable unplugged, router solicitations will only start once you plug in the cable.
Issues/PRs references
similar to #14688