boards/esp32s3-pros3: Fix stdio kconfig model #19708
Conversation
MrKevinWeiss
added
the
CI: ready for build
github-actions
bot
added
Area: boards
|
bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
oh man, I forgot to push the enable nightly commit... Should we just move on it and monitor the next nightly. It takes a really long time to verify locally and so far I could not find any issues. |
|
local usb based tests and hello world pass... |
boards/esp32s3-pros3/Kconfig
Outdated
| @@ -25,6 +25,7 @@ config BOARD_ESP32S3_PROS3 | |||
| select HAS_TINYUSB_DEVICE | |||
| # Only this board has a requirement to use USB_BOARD_RESET with STDIO_USB_SERIAL_JTAG | |||
| select MODULE_USB_BOARD_RESET if MODULE_STDIO_USB_SERIAL_JTAG | |||
| select MODULE_USBUS_CDC_ACM if MODULE_USBUS | |||
There was a problem hiding this comment.
Wouldn't it be more accurate to select this if the corresponding stdio is set?
There was a problem hiding this comment.
It cannot set the MODULE_STDIO_CDC_ACM without MODULE_USBUS_CDC_ACM which is why the MODULE_STDIO_USB_SERIAL_JTAG gets chosen.
Normally there would be a FORCE_USB_STDIO which would select the REQUIRES_USB_STDIO that would automatically bring it in with MODULE_USBUS,
Maybe instead we do:
| select MODULE_USBUS_CDC_ACM if MODULE_USBUS | |
| select REQUIRES_USB_STDIO if MODULE_USBUS || MODULE_TINYUSB_DEVICE |
I just ran, it seems like it would pass:
$ ./dist/tools/compile_test/compile_like_murdock.py -j 8 -a examples/hello-world/ tests/sys/fido2_ctap/ tests/sys/usbus_cdc_acm_stdio/ tests/sys/usbus_hid/ tests/sys/usbus_board_reset/ tests/sys/usbus_cdc_ecm/ tests/sys/usbus_msc/ tests/pkg/tinyusb_cdc_acm_stdio/ tests/pkg/tinyusb_netdev/ tests/pkg/tinyusb_cdc_msc/ -b esp32s3-pros3 -v
examples/hello-world/ esp32s3-pros3 PASS
tests/sys/fido2_ctap/ esp32s3-pros3 PASS
tests/sys/usbus_cdc_acm_stdio/ esp32s3-pros3 PASS
tests/sys/usbus_hid/ esp32s3-pros3 PASS
tests/sys/usbus_board_reset/ esp32s3-pros3 PASS
tests/sys/usbus_cdc_ecm/ esp32s3-pros3 PASS
tests/sys/usbus_msc/ esp32s3-pros3 PASS
tests/pkg/tinyusb_cdc_acm_stdio/ esp32s3-pros3 PASS
tests/pkg/tinyusb_netdev/ esp32s3-pros3 PASS
tests/pkg/tinyusb_cdc_msc/ esp32s3-pros3 PASS
This took 0:07:24.991030...
You could have 17799.641200000002 meters driven in a Tesla
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Contribution description
Always something...
It seems like the desired behaviour (if we use
MODULE_USBUS, then override theMODULE_STDIO_USB_SERIAL_JTAG) requires selection of MODULE_USBUS_CDC_ACM. Seems to be a bit of a corner case.Testing procedure
Let's see if murdock can test faster than my cpu.
Issues/PRs references
Failure in master